Skip to content

Make the logic that get BackendUrl simplify. #1969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Make the logic that get BackendUrl simplify. #1969

wants to merge 3 commits into from
+9 −8

Conversation

@Jaehwa-Noh
Copy link
Contributor

@Jaehwa-Noh Jaehwa-Noh commented Sep 28, 2025 •
edited
Loading

What I have done and why

Remove map and replace Provider<Any> to plain String.
@Jaehwa-Noh
Make BackendUrl Simplify.
e290360 
Change-Id: I45594670e258f041161b275f46c453bb756e77df
@Jaehwa-Noh Jaehwa-Noh requested a review from dturner as a code owner September 28, 2025 07:52
@liutikas
Copy link
Collaborator

liutikas commented Oct 28, 2025

How is this simplifying anything?
@Jaehwa-Noh
Copy link
Contributor Author

Jaehwa-Noh commented Oct 28, 2025

@liutikas This is a passing string type of url directly without any additional behavior, as currently using a map to get string.
@Jaehwa-Noh
Pass BuildConfigField provider.
3fc24ef 
Change-Id: I07c76076c6d64d6067c650c5436e8d8ca851381f
@Jaehwa-Noh
Copy link
Contributor Author

Jaehwa-Noh commented Nov 16, 2025 •
edited
Loading

Made a code can be read easily.
@Jaehwa-Noh
Add double quotation.
c634bb7 
Change-Id: I9d8f2fcef7253d2ebdbfe4dea7cb9d5b8f805439
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@Jaehwa-Noh @liutikas