Provide a generic json mapper for any entity. #183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| * @throws com.google.gson.JsonSyntaxException if the json string is not a valid json structure. | ||
| */ | ||
| public UserEntity transformUserEntity(String userJsonResponse) throws JsonSyntaxException { | ||
| public T transformUserEntity(String json) throws JsonSyntaxException { |
There was a problem hiding this comment.
If this is a generic entity mapper, then I think the naming of this methods should reflect it, they can be transfromFromEntity and transfromFromEntityCollection
Author
There was a problem hiding this comment.
Oops! Good catch!
Just fixed it, thanks.
alexandru-calinoiu approved these changes Sep 19, 2016
…chitecture into provide_generic_jason_mapper
Author
| @android10 Just updated my PR and resolved merge conflicts. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Hi Fernando,
I changed
UserEntityJsonMapperto a generic class namedEntiityJsonMapper, so I can deserialize any kind of entity.Hope you like it!