Skip to content

Conversation

@jspdown
Copy link
Member

@jspdown jspdown commented Mar 14, 2015

I wasn't able to use the dropdown because of missing classes on <div class="menu">.
This div must have the following classes to work:

<div class="menu transition visible"> </div>

The transition class is not compulsory but add a nice effect
After those change done, I got other issues:

  • The scope.open property was supposed to be string but we stored a boolean. So, an equality check with a boolean value failed
  • Sometime, the scope.model was updated with the original title and not undefined
  • If scope.model == undefined, the title of the dropdown was set to the undefined instead of the original name
  • The var title in the dropdown-group wasn't used. So, if no title was provided for this directive, after selection, we set the dropdown title to undefined

Those points are fixed.
Dropdown closed:
screen shot 2015-03-14 at 3 54 08 pm
Dropdown opened:
screen shot 2015-03-14 at 3 54 03 pm

This pull-request also include an update of the dropdown/doc/ files

…fter a click on a dropdown-group. Improved demo.html.
0xAX added a commit that referenced this pull request Mar 14, 2015
@0xAX 0xAX merged commit f6aa052 into angularify:master Mar 14, 2015
@0xAX
Copy link
Member

0xAX commented Mar 14, 2015

Thank you @jspdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants