Make dropdown openable #17
Merged
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I wasn't able to use the dropdown because of missing classes on
<div class="menu">.This div must have the following classes to work:
The
transitionclass is not compulsory but add a nice effectAfter those change done, I got other issues:
scope.openproperty was supposed to be string but we stored a boolean. So, an equality check with a boolean value failedscope.modelwas updated with the original title and notundefinedscope.model == undefined, the title of the dropdown was set to theundefinedinstead of the original namevar titlein the dropdown-group wasn't used. So, if no title was provided for this directive, after selection, we set the dropdown title toundefinedThose points are fixed.


Dropdown closed:
Dropdown opened:
This pull-request also include an update of the
dropdown/doc/files