Skip to content

Conversation

@kevspadillo
Copy link

// <accordion styled></accordion> if(typeof attrs.styled !== 'undefined') { element.addClass('styled'); } 

Added styled attribute to display accordion with border

template: "<div class=\"ui accordion\">\ 

to

 template: "<div class=\"ui\">\ 

Removed accordion class selector to display grouped accordions

@jspdown
Copy link
Member

jspdown commented Apr 15, 2015

@kevspadilla: I got an error when I clicked a second time on the same tab:

TypeError: undefined is not a function at n.scope.click_on_accordion_tab (src/accordion/accordion.js:120:36) at ib.functionCall (bower_components/angular/angular.min.js:199:303) at Ec.(anonymous function).compile.d.on.f (bower_components/angular/angular.min.js:216:74) at n.$get.n.$eval (bower_components/angular/angular.min.js:126:15) at n.$get.n.$apply (bower_components/angular/angular.min.js:126:241) at HTMLDivElement.<anonymous> (bower_components/angular/angular.min.js:216:126) at HTMLDivElement.c (bower_components/angular/angular.min.js:32:389) 
@kevspadillo
Copy link
Author

Hi! @jspdown ,
Error message doesn't show in mine. It seems there's an error regarding this line of code.

// Add animation to the accordion group content element.children().last().slideToggle(); 

Please see this fiddle...
http://jsfiddle.net/kevs017/3dvg6Lkf/2/

@jspdown
Copy link
Member

jspdown commented Apr 16, 2015

@kevspadilla, I'm sorry, something wrong happened when I checkout your commit. It works now.
Thanks for your PR 😉

jspdown added a commit that referenced this pull request Apr 16, 2015
Add styled and animation to accordion
@jspdown jspdown merged commit 7df3b68 into angularify:master Apr 16, 2015
@kevspadillo
Copy link
Author

Your very much welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants