Skip to content

Conversation

@Kurmaev
Copy link
Contributor

@Kurmaev Kurmaev commented May 10, 2015

Simplify dropdown widget.
Add support for custom dropdown values.

@jspdown
Copy link
Member

jspdown commented May 12, 2015

Thanks @Kurmaev. Your patch simplify clearly the dropdown component!
Could you please update src/dropdown/test/spec.js and src/dropdown/docs/demo.html files ?

@Kurmaev
Copy link
Contributor Author

Kurmaev commented May 12, 2015

@jspdown yes I planning to do it at weekend

@jspdown
Copy link
Member

jspdown commented May 13, 2015

PR #37 has been merged and improve some part of the dropdown components. Please, remember to update your local branch.

Kurmaev added 2 commits May 13, 2015 22:45
 - Add support for custom dropdown values. - Dropdown wraper are inits before options are rendered, so check model value on every new added option - Clean stalled dropdown options when options list are changed
@Kurmaev
Copy link
Contributor Author

Kurmaev commented May 14, 2015

@jspdown My code is rebased on top of master branch; some commits are squashed. Updated demo page and actualized test specs for it.

jspdown added a commit that referenced this pull request May 15, 2015
@jspdown jspdown merged commit 6d2429d into angularify:master May 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

2 participants