Skip to content

Conversation

@rmanno91
Copy link
Contributor

@rmanno91 rmanno91 commented Sep 2, 2022

In this PR an example regarding composite material debonding has been added.
The example make use of PyDPF for post-processing

@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2022

Please add one of the following labels to add this contribution to the Release Notes 👇

@codecov
Copy link

codecov bot commented Sep 2, 2022

Codecov Report

Merging #1441 (d8f68a0) into main (7f95006) will increase coverage by 4.23%.
The diff coverage is n/a.

@@ Coverage Diff @@ ## main #1441 +/- ## ========================================== + Coverage 78.00% 82.24% +4.23%  ========================================== Files 43 43 Lines 6843 6843 ========================================== + Hits 5338 5628 +290  + Misses 1505 1215 -290 
@akaszynski
Copy link
Collaborator

Nice work! Next time, use precommit. It basically just makes sure that you don't push code that doesn't adhere to our style. See Code Style. Since it's your first PR (and we love those) I'll clean it up for you and make some other style changes.

@rmanno91
Copy link
Contributor Author

rmanno91 commented Sep 2, 2022

Thanks Alex! Next time I will definitely use that 👍

Copy link
Collaborator

@germa89 germa89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @rmanno91 !! It is a very nice example. I will need to fix something before this is finally deployed on the CICD, so stay tunned.

I left some minor suggestions, mainly style and such.

I would like also get the opinion of @PProfizi about the DPF part.

I'm pinging @PipKat for grammar/spelling review.

@germa89
Copy link
Collaborator

germa89 commented Sep 21, 2022

This cannot be merged until #1449 is merged.

rmanno91 and others added 3 commits September 22, 2022 16:35
Co-authored-by: German <28149841+germa89@users.noreply.github.com>
Co-authored-by: German <28149841+germa89@users.noreply.github.com>
Co-authored-by: German <28149841+germa89@users.noreply.github.com>
rmanno91 and others added 22 commits September 27, 2022 11:56
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
@github-actions github-actions bot added CI/CD Related with CICD, Github Actions, etc Maintenance labels Oct 24, 2022
@germa89
Copy link
Collaborator

germa89 commented Oct 24, 2022

@rmanno91 I'm merging this. Only the image is missing, which I added one. Feel free to do a PR to replace it by your image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/CD Related with CICD, Github Actions, etc

6 participants