- Notifications
You must be signed in to change notification settings - Fork 140
revert: "test: removing composite example" #4000
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit 917ca90.
| Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @germa89 - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 4 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| @PProfizi @rafacanton could you have a look at this commit and tell me if this is the best approach to consider both cases, a remote DPF server running on port This is the commit: cc5a3f3 |
| I think I could also use |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@ ## main #4000 +/- ## ========================================== + Coverage 89.12% 89.13% +0.01% ========================================== Files 187 187 Lines 14970 14970 ========================================== + Hits 13342 13344 +2 + Misses 1628 1626 -2 🚀 New features to boost your workflow:
|
…ed boundary condition titles
| Elements selections seems to have problems still when not all the nodes are selected for the elements we want to plot. Related to #3782 |
@germa89 I see a couple of things:
|
| Because DPF is running on a container, and that container binds the port 50055, I just need to tell the port because the IP is "local". I was trusting on the Thank you a lot @rafacanton ! |
| It looks great. Pinging @rmanno91 for awareness. Sorry it took so long! |
| @pyansys-ci-bot LGTM. |
pyansys-ci-bot left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.

This reverts commit 917ca90.
Description
This PR readd the composite DPF example which was removed because of failures.
Issue linked
Close #3486
Checklist
draftif it is not ready to be reviewed yet.feat: adding new MAPDL command)Summary by Sourcery
Revert the previous removal of the composite example by restoring the
composite_dcb.pydemonstration and updating the changelog accordinglyNew Features:
Documentation: