feat(tablegen): add MLIR TableGen grammar #4107
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
kaby76 reviewed May 24, 2024
kaby76 reviewed May 25, 2024
| | ||
| // ArgValueList ::= PostionalArgValueList [","] NamedArgValueList | ||
| argValueList | ||
| : positionalArgValueList (',')? namedArgValueList |
Contributor
There was a problem hiding this comment.
Perhaps you could remove the extra parentheses here and in a few other places?
$ bash /c/Users/Kenne/Documents/GitHub/g4-scripts/find-useless-parentheses.sh Using built-in parser. CSharp 0 TableGen.g4 success 0.0477444 Computing useless parentheses in TableGen.g4 Using built-in parser. CSharp 0 TableGen.g4 success 0.0477226 Found useless parentheses in grammars... TableGen.g4:L100: : positionalArgValueList (',')? namedArgValueList ^ TableGen.g4:L333: : '(' dagArg (dagArgList)? ')' ^ TableGen.g4:L460: DecimalInteger : ('+' | '-')? (UDigit)+; ^ TableGen.g4:L464: TokIdentifier : (UDigit)* UAlpha (UAlpha | UDigit)*; ^ TableGen.g4:L455: TokString : '"' (~('"') | Escape)* '"'; ^ TableGen.g4:L457: TokCode : '[{' (~(']') | ']' ~('}') | Escape)*? '}]'; ^ TableGen.g4:L457: TokCode : '[{' (~(']') | ']' ~('}') | Escape)*? '}]'; ^ 05/25-06:29:01 ~/issues/g4-4107/tablegen/Generated-CSharp kaby76 reviewed May 25, 2024
| Defset : 'defset'; | ||
| Defvar : 'defvar'; | ||
| Deftype : 'deftype'; | ||
| Field : 'field'; |
Contributor
There was a problem hiding this comment.
Field (and fragment EOL below) are unused. Is something missing?
$ bash /c/Users/Kenne/Documents/GitHub/g4-scripts/find-unused-lexer-symbols.sh No arguments were provided. Finding unused lexer symbols in grammars... ./desc.xml 1st pass: fold string literals in parser rules to make explicit lexer rule used. 2nd pass: find unreferenced lexer rule symbols. Field EOL 05/25-06:32:18 ~/issues/g4-4107/tablegen/Generated-CSharp kaby76 reviewed May 25, 2024
| @@ -0,0 +1,454 @@ | |||
| //===- ToyOps.td - Toy dialect operation definitions -------*- tablegen -*-===// | |||
Contributor
There was a problem hiding this comment.
The coverage for this one test is ~50%, but perhaps you could add additional tests to cover more of the grammar?
$ trcover.exe ../examples/ToyOps.td Parsing grammar C:/msys64/home/Kenne/issues/g4-4107/tablegen/Generated-CSharp/TableGen.g4 CSharp 0 ../examples/ToyOps.td success 0.0336701 Analyzing... Analysis 0 ../examples/ToyOps.td 0.0115427 05/25-06:39:13 ~/issues/g4-4107/tablegen/Generated-CSharp Output: cover.html.txt
teverett added new-grammar 
Member
| Looking at the build results, @kaby76 , is this an bug in the Antlr Python generator? |
Contributor
| The problem is rule True. It's a symbol conflict. |
Member
| Hey this would still be a really nice addition, let me know I can easily help. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
https://llvm.org/docs/TableGen
https://llvm.org/docs/TableGen/ProgRef.html