test(calculateRank): fix floating-point precision issue for B- rank test #4639
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| @vardhan30016 is attempting to deploy a commit to the github readme stats Team on Vercel. A member of the Team first needs to authorize it. |
github-actions bot added the dependencies Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a failing test in
tests/calculateRank.test.jscaused by a minor floating-point precision mismatch in the expected percentile value for the "B-" rank.Details
toStrictEqual()withtoBeCloseTo()for the percentile comparison in the "beginner user gets B- rank" test.calculateRank()implementation itself — only to the test expectation.Motivation
Floating-point calculations may differ slightly across environments and Node.js versions.
Using
toBeCloseTo()ensures test reliability without compromising accuracy.Verification
✅ All tests pass locally with:
npm test