Fix enable_audit_log configuration not taking effect #16838
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the issue where the
enable_audit_logconfiguration was not taking effect, causing audit logs to always remain disabled even when explicitly set totrue.Fixes: #16706
Root Cause
The audit log configuration values were defined as
static finalfields inAbstractAuditLogger:These
static finalfields are initialized at class loading time, which may occur before the configuration file is fully loaded (especially in Docker environments where configuration is injected via environment variables). As a result, these values always get the default value (falseforenable_audit_log).Solution
Changed the
static finalfields to dynamic method calls that read the configuration values at runtime:IS_AUDIT_LOG_ENABLED→isAuditLogEnabled()methodAUDITABLE_OPERATION_TYPE→getAuditableOperationType()methodAUDITABLE_OPERATION_LEVEL→getAuditableOperationLevel()methodAUDITABLE_OPERATION_RESULT→getAuditableOperationResult()methodThis ensures that the configuration values are read dynamically after the configuration file has been properly loaded.
Changed Files
AbstractAuditLogger.javaDNAuditLogger.javaCNAuditLogger.javaTesting
mvn spotless:check)Checklist