Skip to content

Conversation

@Asuka0630
Copy link

This commit fixes tvm.error.InternalError: Check failed: (index_map_func.has_value()) is false in #18472

Why
When using mma for MultiLevelTilingTensorCore, users must manually pass tvm.tir.tensor_intrin as an initializer to register it in LocalBuilder. This is inconsistent with the wmma workflow, where tvm.tir.tensor_intrin is imported by default in tune_context.py to ensure that the TensorIntrin required by wmma is registered in advance. Additionally, the corresponding error message is not straightforward, which can be confusing for new users who are not familiar with TVM.

How
by adding import tensor_intrin in the default_build

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @Asuka0630, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an internal error in TVM's LocalBuilder when using mma for MultiLevelTilingTensorCore. It standardizes the registration of tvm.tir.tensor_intrin by ensuring it's automatically imported during the default build process, aligning its behavior with wmma and improving the clarity of error messages for users.

Highlights

  • Fix tvm.error.InternalError in LocalBuilder: Addresses an InternalError where index_map_func.has_value() is false, specifically when using mma with MultiLevelTilingTensorCore.
  • Ensure tvm.tir.tensor_intrin is registered by default: Resolves the inconsistency where mma required manual registration of tvm.tir.tensor_intrin, unlike wmma, by automatically importing it in the default_build function. This also improves the user experience by preventing a confusing error message.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly fixes an issue where MMA tensor intrinsics were not being registered by default in the LocalBuilder, unlike the existing WMMA workflow. By adding import tvm.tir.tensor_intrin to default_build, the necessary intrinsics are now registered via side-effects, which resolves the Check failed: (index_map_func.has_value()) is false error and improves the user experience. The change is simple and effective. I have included a minor suggestion regarding import order to align with coding best practices.

Comment on lines 257 to +258
from tvm.tir.transform import RemoveWeightLayoutRewriteBlock
import tvm.tir.tensor_intrin
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve code readability and maintainability, it's good practice to keep imports sorted alphabetically, as recommended by PEP 8. The tvm.tir.tensor_intrin import should come before tvm.tir.transform.

Suggested change
from tvm.tir.transform import RemoveWeightLayoutRewriteBlock
import tvm.tir.tensor_intrin
import tvm.tir.tensor_intrin
from tvm.tir.transform import RemoveWeightLayoutRewriteBlock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant