Skip to content

Conversation

@robbert229
Copy link
Contributor

Keeper Secrets Manager can return multiple records with the same uid. This is because KSM is now returning a secret for each time a secret is referenced. This breaks previous assumptions.

Description

Removing previous ksm sanity check ensuring a record is only returned once, and added supporting tests.

Checklist

Please make sure that your PR fulfills the following requirements:

  • Reviewed the guidelines for contributing to this repository
  • The commit message follows the Conventional Commits Guidelines.
  • Tests for the changes have been updated
  • Are you adding dependencies? If so, please run go mod tidy -compat=1.21 to ensure only the minimum is pulled in.
  • Docs have been added / updated
  • Optional. My organization is added to USERS.md.

Type of Change

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

Other information

I implemented the original keeper secrets manager functionality back in #468.

@robbert229 robbert229 force-pushed the bugfix/keeper-secrets-manager branch from 44df351 to e585d00 Compare July 8, 2024 20:58
@robbert229 robbert229 force-pushed the bugfix/keeper-secrets-manager branch from e585d00 to f8ee3f4 Compare July 8, 2024 21:03
@codecov-commenter
Copy link

codecov-commenter commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.57%. Comparing base (42a43f0) to head (c355157).
Report is 16 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@ ## main #652 +/- ## ========================================== - Coverage 72.16% 71.57% -0.59%  ========================================== Files 26 29 +3 Lines 1994 2600 +606 ========================================== + Hits 1439 1861 +422  - Misses 458 588 +130  - Partials 97 151 +54 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
Keeper Secrets Manager can return multiple records with the same uid. This is because KSM is now returning a secret for each time a secret is referenced. This breaks previous assumptions. Signed-off-by: John Rowley <johnrowleyster@gmail.com>
@robbert229 robbert229 force-pushed the bugfix/keeper-secrets-manager branch from f8ee3f4 to c355157 Compare April 18, 2025 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants