feat: add shouldExclude option to pluginStrictTokenScope

[k35o]

Close #54

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
pandabox-z5kx	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 31, 2024 3:14am

[astahmer]

I think the excludeCategories: ['colors', 'spacing'] made more sense here instead of a boolean

[k35o]

I fix it.

[astahmer]

in my mind, this feature could be done simply by re-using the current logic in transformPropTypes and filling the categories with every possible TokenCategory (when excludeCategories is not empty) then filtering the array using excludeCategories

something like:

const allCategories = ["zIndex", "opacity", "colors", "fonts", "fontSizes", "fontWeights", "lineHeights", "letterSpacings", "sizes", "shadows", "spacing", "radii", "borders", "durations", "easings", "animations", "blurs", "gradients", "assets", "borderWidths", "aspectRatios", "containerNames"] // excludeCategories: ['colors', spacing'] -> allCategories.filter((cat) => !excludeCategories.include(cat))

[k35o]

We noticed that the type of values not included in CssProperties, such as textStyle, is broken, although from existing.

The type below will be any.

{ textStyle?: ConditionalValue<UtilityValues["textStyle"] | CssProperties["textStyle"]> }

I had to fix it in a separate issue or pr.

And, incidentally, that did not happen with the first way it was implemented.

if (strictTokenProps.includes(prop)) { const longhand = ctx.utility.shorthands.get(prop); return `${prop}?: ConditionalValue<${value} | CssProperties["${longhand || prop}"]>`; }; return match;