Skip to content

Conversation

@ashchenn
Copy link
Contributor

Issue #, if available: N/A Discussed with Shreyas on the proposed changes via slack. Below edits are minor and are quick fix for an upcoming workshop of mine

Description of changes:

  1. In text generation module, removed Deepseek model as the converse response doesn't match the expected response syntax. Happy to take a deep dive next week
  2. In KB module - Create KB and Ingest Documents, I modified the pip install command as multiple teammates ran into pip dependency issues
  3. In KB module - Create KB and Ingest Documents, I modified the S3 bucket suffix randrange (100,99999) as we run out of unique suffix. In next iteration we should think of different approach (maybe using Python's uuid?) to make it more resilient.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Contributor

@w601sxs w601sxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving

@w601sxs w601sxs merged commit 7ac4b4c into aws-samples:main Nov 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants