Adding aws ecr option to avoid docker login error #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
| Thanks! |
humbleonholiday added a commit to humbleonholiday/amazon-ecs-nodejs-microservices that referenced this pull request Feb 2, 2022
lowe_higher and removed name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What
Adding
--no-include-emailto theaws ecr get-logincommand in thedeploy.shscripts for cases number 2 and 3Why
the
aws ecr get-logincommand was triggering an error (unknown shorthand flag: 'e' in -e) while login into the repo which prevents thedocker pushcommands to succeed