New OSX path option (revised) #89
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Move --force option to front of options list (compatibility processing 3.0b5)
users who still have older versions of processing-java installed. Later versions of Processing 3 betas remove the old processing-java installed in /usr/bin, so this is probably no longer a big deal. However, this simple re-ordering of the path helps 'protect' some users who are running older Processing 3 betas. Fixes issues discussed in PR b-g#88. References: processing/processing#3786 processing/processing#3497 b-g#88
Collaborator Author
| @b-g I closed the previous PR and have a new one. This should do it. I reinstalled the old usr/bin/processing-java as well as having usr/local/bin/processing-java and this now works as expected. |
Owner
| Thanks! Works! And merged to dev branch via the green button :) |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Note: This revised PR addresses the issue discussed in #88.
This revision reorders the directories in the
pathoption, to help insulate Processing 3 beta users from a problem that occurs if the old /usr/bin/processing-java still exists. Note that Processing 3b6 fixed this issue by deleting the old /usr/bin/processing-java, so this will never be an issue for new users anyway; but this helps our package users who may be using earlier betas, and who install new versions of Processing 3, without re-installing processing-java.Fixes #86, #81, #80.
Processing 3 installs processing-java in /usr/local/bin instead of /usr/bin. On OSX, this is a problem, because Sublime Text does not use the user's
PATH. This can easily be addressed by installing the "Fix Mac Path" package, which all OSX users should probably install anyway, but it would be better to make the "out of box" experience for this package work without installing another package.This PR adds
osxplatform-specific options forpath. What's nice is that we declare it at the top level of the build system and all variants inherit it (no need to duplicate the option for all variants).