Fix benchmark #597
Merged
Fix benchmark #597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This pull request updates the Lotka-Volterra and SIR benchmark simulators to be in line with the benchmark of Lueckmann. The changes allow for more accurate reproduction of original benchmark tasks:
'original'option in thesubsampleparameter for bothlotka_volterra.pyandsir.pysimulators, enabling users to reproduce the exact subsampling easily.np.linspacetonp.arangeto get the same time steps as in Lueckmann et. al.lotka_volterra.pysimulations are now clipped to a minimum of1e-10and a maximum of10000.0before applying noise, instead of thelog1p, which migth be nicer but deviates from the original benchmark.