cargo_build_script: normalize CARGO_MANIFEST_DIR in cargo_build_script #3689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
UebelAndre requested changes Oct 22, 2025
Collaborator
UebelAndre left a comment
UebelAndre left a comment There was a problem hiding this comment.
Thanks! Normalizing seems good but I'm still curious what the impact is. Also, this method of normalization seems funny, I would agree something like paths.normalize might make more sense but it also sounded like the issue was just a missing .rstrip("/")?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #3247 by normalizing the CARGO_MANIFEST_DIR path in cargo_build_script to ensure it doesn't end with trailing slashes.
The issue occurs because CARGO_MANIFEST_DIR in cargo_build_script doesn't clean the path like in rust.bzl and rustc.bzl, leading to inconsistent paths that can cause problems for build scripts.
Fixes #3247