Skip to content

Conversation

@prograhamming
Copy link
Contributor

@prograhamming prograhamming commented Dec 2, 2025

🎟️ Tracking

PM-23358

📔 Objective

Phishing Blocker feature is now is frontend only and the BEEP server side code needs to be removed.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes
@claude
Copy link
Contributor

claude bot commented Dec 2, 2025

Claude encountered an error —— View job


I'll analyze this and get back to you.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2025

Logo
Checkmarx One – Scan Summary & Details095548f6-99c2-49f1-9b02-e15f7d63007f

Great job! No new security vulnerabilities introduced in this pull request

@codecov
Copy link

codecov bot commented Dec 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 53.59%. Comparing base (b3573c1) to head (b6830f6).

Additional details and impacted files
@@ Coverage Diff @@ ## main #6668 +/- ## ========================================== - Coverage 57.24% 53.59% -3.65%  ========================================== Files 1910 1904 -6 Lines 85156 84830 -326 Branches 7651 7620 -31 ========================================== - Hits 48748 45468 -3280  - Misses 34576 37604 +3028  + Partials 1832 1758 -74 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
Copy link

@Banrion Banrion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deletions look good to me. Do we need any additional migrations to remove tables or cleanup any jobs?

@prograhamming
Copy link
Contributor Author

prograhamming commented Dec 2, 2025

Deletions look good to me. Do we need any additional migrations to remove tables or cleanup any jobs?

Yeah good callout. It looks like from the old code they added a JSON blob to a Azure Storage service and nothing to the relational databases we support. The only migration script related to Phishing Blocker I can find is Vijay's migrations (completed on 11/20/2025) adding theUsePhishingBlocker field to the Organization table and view related to that table.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants