support c-style arrays #189
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Author
| the tests still fail though: |
| Very interested in seeing this through, let me know if I can help in any way! |
Member
std::is_aggregate is not available in C++14, but just ignore that issue for now. Make sure that the PR builds in С++20 or C++17 mode. Any modern enough compiler is fine for that, clang-18 is fine. |
Nagisaaaaaaaaa added a commit to Nagisaaaaaaaaa/ARIA that referenced this pull request Feb 6, 2025
1. Support C arrays as `MosaicPattern` members. 1.1. Use the fixed `boost::pfr` to support C arrays, see boostorg/pfr#189. 1.2. Extend the `Mosaic` system to support C arrays as `MosaicPattern` members. 1.3. Check `boost::pfr` limitations and undefined behaviors at compile time. 2. Add policy-based `Vector` which supports auto SoA. 2.1. Implemented with type reduction. 2.2. Fully test compatibility with different `Mosaic`s, including `Vec<T, size>`.
denzor200 reviewed Mar 6, 2025
| }; | ||
| | ||
| template <class T, std::size_t I0, std::size_t... I, class /*Enable*/ = std::enable_if_t<std::is_copy_constructible<T>::value>> | ||
| template <class T, std::size_t I0, std::size_t... I, class /*Enable*/ = std::enable_if_t<std::is_copy_constructible<T>::value and !std::is_aggregate_v<T>>> |
Contributor
There was a problem hiding this comment.
please provide unit-test to check that boost::pfr::tuple_size for a structure with c-style array field returns real count of fields
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
this tries to implement the solution in #170, with one change: I saw some "must be aggregate initializable" errors so I added another case depending on
std::is_aggregate_v<T>