Fix issue that unintended installataion of tests/bsv module due to configuration error in setup.py #129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a package configuration issue in setup.py where test modules were being unintentionally installed into site-packages. By adding 'tests.*' to the exclusion pattern, all test subpackages (including tests/bsv) are now properly excluded from installation, preventing potential conflicts with the actual bsv package.
Key Changes:
- Updated the
find_packages()exclude parameter to include both'tests'and'tests.*'patterns
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description of Changes
Current
setup.pyexcludestestsdirectory, but we also needtests.*to exclude all test codes.This results unintended installation of
test/bsvmodule for site-packages.It causes confilict to test code for any package..
This PR fixes this problem.
Linked Issues / Tickets
N/A
Testing Procedure
Describe the tests you've added or any testing steps you've taken.
Checklist:
CHANGELOG.mdwith my changes