fix: upload sync messages only with the primary transport #7528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
link2xt force-pushed the link2xt/ltkmzmwtwzym branch from 0bc42b7 to 977f366 Compare 
Collaborator Author
| This is needed for #7485, but can already be reviewed and merged separately. |
Currently there is a race between transports to upload sync messages and delete them from `imap_send` table. Sometimes mulitple transports upload the same message and sometimes only some of them "win". With this change only the primary transport will upload the sync message.
link2xt force-pushed the link2xt/ltkmzmwtwzym branch from 977f366 to b2d2fbb Compare Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Currently there is a race between transports
to upload sync messages and delete them from
imap_sendtable. Sometimes mulitple transports upload the same message and sometimes only some of them "win".With this change only the primary transport
will upload the sync message.