Implement languageChanged event #119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
| I'll review it today 👍 |
Contributor
| @mikehaertl changes look good. I also like how clean the tests are 👍 |
Collaborator Author
| @ddinchev Great, thanks for your help. I'm sure, there will be some side effects I didn't think about. But I'll merge now and give it a try in a concrete app. |
mikehaertl force-pushed the language-changed-event branch from acf531d to 4c7bb37 Compare Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
@ddinchev As you seem interested in this project, maybe you want to have a look at this implementation.
Note, that apart from the test case I did not test this code yet. So especially the example given in the README should be taken with care.
I'd appreciate any feedback.