Add "Yii::$app->end();" after redirect #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
| Oops, I totally missed this pull request, sorry. Thanks for pointing that out. I wasn't aware that in yii2 the app is not ended anymore if you call |
mikehaertl added a commit that referenced this pull request Jan 7, 2015
Add "Yii::$app->end();" after redirect
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
To avoid the "$application->run();" after the redirect.
Without the end() call, the page will be rendered but not show because of the "302" of the answer, than it will be rendered again.
This's a big wasting resources and, that was my the problem, "burn" the flash messages.