Test for all #10
Merged
Test for all #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Based on - Kx - Au - Enc - Mac Signed-off-by: Christoph Kappel <kappel.christoph@gmail.com>
- ECDH(E) is the recommended KX - everything else should be disabled Signed-off-by: Christoph Kappel <kappel.christoph@gmail.com>
- ECDSA or RSA are recommended - everything else should be disabled Signed-off-by: Christoph Kappel <kappel.christoph@gmail.com>
- AES256, AES128, AES256-GCM, AES128-GCM, CHACHA20 are allowed - everything else should be disabled Signed-off-by: Christoph Kappel <kappel.christoph@gmail.com>
- SHA384, SHA256 and POLY1305 are recommended - everything else should be disabled - Added Authors Patrick Münch and Christoph Kappel to file Signed-off-by: Christoph Kappel <kappel.christoph@gmail.com>
This was the only english comment rule in rubocop, Since @atomic111 has an non ASCII char in his name, i disabled this. Signed-off-by: Christoph Kappel <kappel.christoph@gmail.com>
Member
| @supergicko wow, great!!!! I will have a closer look later. great work |
Member Author
| also need to keep in mind, that if we just the ciphersuites of #8 are enabled - arlimus/sslshake#7 must be done also because otherwise the ssl resource will not work properly. |
Member
| @supergicko sorry for the late response. thank you for your work. really great!!! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Hi
tried to cover everything as discussed in #8
Ready / Open for discussions 🎉
Cheers