Surface language implementation for validating crypto keys #22431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
carlpulley-da commented Nov 26, 2025
| -- All rights reserved. | ||
| | ||
| -- @SINCE-LF 2.dev | ||
| -- @SINCE-LF 2.1 |
Contributor Author
There was a problem hiding this comment.
I'm observing secp256k1WithEcdsaOnly in daml_2.1.lf, so figure this should always have been since 2.1?
carlpulley-da commented Nov 26, 2025
| where | ||
| signatory owner | ||
| ensure secp256k1 signature (keccak256 (serialize burnMessage)) publicKey | ||
| ensure secp256k1WithEcdsaOnly signature (keccak256 (serialize burnMessage)) publicKey |
carlpulley-da commented Nov 26, 2025
| testKeyPairSignature <- secp256k1sign testKeyPair.privateKey expectedDigest | ||
| (secp256k1 testKeyPairSignature expectedDigest testKeyPair.publicKey === True) | ||
| actualSignatureWithEcdsaAndSha256 <- secp256k1signWithEcdsaOnly testKeyPair.privateKey (sha256 expectedDigest) | ||
| (secp256k1 actualSignatureWithEcdsaAndSha256 expectedDigest testKeyPair.publicKey === True) |
carlpulley-da commented Nov 26, 2025
| actualSignatureWithEcdsaAndSha256 <- secp256k1signWithEcdsaOnly privateKey1 (sha256 expectedDigest) | ||
| actualSignature <- secp256k1sign privateKey1 expectedDigest | ||
| (actualSignatureWithEcdsaAndSha256 === actualSignature) | ||
| actualSignature <- secp256k1signWithEcdsaOnly privateKey1 expectedDigest |
Contributor Author
There was a problem hiding this comment.
Simplification
remyhaemmerle-da approved these changes Dec 2, 2025
Comment on lines +101 to +102
| | not (isDEREncoded pk) = error $ "Public key argument is not a DER encoded hex string: " <> pk | ||
| | otherwise = primitive @"BESecp256k1ValidateKey" (Text.asciiToLower pk) |
Collaborator
There was a problem hiding this comment.
I think we should do the validation and lower case translation in scala directly, to avoid excessive in cost in gaz.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
SECP256K1_VALIDATE_KEYprimitive to Damlsecp2561WithValidationandvalidatePublicKeyDaml functions