Skip to content

Added a test for Issue #1127 #1131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Added a test for Issue #1127 #1131

wants to merge 1 commit into from
+77 −0

Conversation

@sei-vsarvepalli
Copy link
Contributor

@sei-vsarvepalli sei-vsarvepalli commented Dec 2, 2025

Basic test case for Issue #1127 already resolved in last PR #1128 as requested in #1129

This is entirely optional test case to ensure we have reliable test cases for this issue that was raised by @dmitrc
@davidlehn
Copy link
Member

davidlehn commented Dec 3, 2025

  • I think this is probably better in tests/unit/pkcs12.js with the other related tests? Maybe with a comment it was for issue 1127.
  • Remove the async. Not needed here and it breaks the silly check we have for node 6(!).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@sei-vsarvepalli @davidlehn