[typescript-operations] Add missing enum tests for standalone approach #10525
+1,480 −64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
|
This was referenced Nov 30, 2025
eddeee888 commented Dec 3, 2025
Comment on lines -814 to -865
| protected _buildTypeImport(identifier: string, source: string, asDefault = false): string { | ||
| const { useTypeImports } = this.config; | ||
| if (asDefault) { | ||
| if (useTypeImports) { | ||
| return `import type { default as ${identifier} } from '${source}';`; | ||
| } | ||
| return `import ${identifier} from '${source}';`; | ||
| } | ||
| return `import${useTypeImports ? ' type' : ''} { ${identifier} } from '${source}';`; | ||
| } | ||
| | ||
| protected handleEnumValueMapper( | ||
| typeIdentifier: string, | ||
| importIdentifier: string | null, | ||
| sourceIdentifier: string | null, | ||
| sourceFile: string | null | ||
| ): string[] { | ||
| if (importIdentifier !== sourceIdentifier) { | ||
| // use namespace import to dereference nested enum | ||
| // { enumValues: { MyEnum: './my-file#NS.NestedEnum' } } | ||
| return [ | ||
| this._buildTypeImport(importIdentifier || sourceIdentifier, sourceFile), | ||
| `import ${typeIdentifier} = ${sourceIdentifier};`, | ||
| ]; | ||
| } | ||
| if (sourceIdentifier !== typeIdentifier) { | ||
| return [this._buildTypeImport(`${sourceIdentifier} as ${typeIdentifier}`, sourceFile)]; | ||
| } | ||
| return [this._buildTypeImport(importIdentifier || sourceIdentifier, sourceFile)]; | ||
| } | ||
| | ||
| public getEnumsImports(): string[] { | ||
| return Object.keys(this.config.enumValues) | ||
| .flatMap(enumName => { | ||
| const mappedValue = this.config.enumValues[enumName]; | ||
| | ||
| if (mappedValue.sourceFile) { | ||
| if (mappedValue.isDefault) { | ||
| return [this._buildTypeImport(mappedValue.typeIdentifier, mappedValue.sourceFile, true)]; | ||
| } | ||
| | ||
| return this.handleEnumValueMapper( | ||
| mappedValue.typeIdentifier, | ||
| mappedValue.importIdentifier, | ||
| mappedValue.sourceIdentifier, | ||
| mappedValue.sourceFile | ||
| ); | ||
| } | ||
| | ||
| return []; | ||
| }) | ||
| .filter(Boolean); |
Collaborator Author
There was a problem hiding this comment.
These utility functions are now abstracted to be shared between base-types-visitor and typescript-operations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
This is the continuation of #10508. We merged that PR early to unblock the enum-in-input scenario
Related #10496
Type of change
How Has This Been Tested?