DP-499 Integrate SSO #45
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
danmun reviewed Jul 6, 2022
| } | ||
| | ||
| if (($this->generateToken($credentials) === $credentials['sso_token']) && ($credentials['timestamp'] > (time() - 120))) { | ||
| $credentials['is_active'] = 1; |
There was a problem hiding this comment.
@tomonorman @krishnapriawan
Can you please elaborate, what's the purpose of this is_active?
Contributor Author
There was a problem hiding this comment.
Part of the laravel Login authentication. Users can be active or inactive (Rather than just deleted). Its set here to check against the db (make sure same there).
But I think you have a point. given the integrate login is a separate process this may not be necessary in this function
There was a problem hiding this comment.
Okay thanks for clarifying. Up to you whether you want to remove it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
in conjunction with dreamfactorysoftware/df-core@develop...DP-499 of DF Core