Added AL2023 support for Outpost nodes #8591
Open
+4,597 −80
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
AL2 is on deprecation path, making AL2023 the only supported operating
system for node-groups on Outpost. Using AL2 will now cause validation
error. Leaving the AL2 code in place, to be deleted after this OS is
officially deprecated.
Some mocks/dependencies got updated too, I'm including them in the PR, not sure if that's how you guys do it.
Checklist
README.md, or theuserdocsdirectory) (kind of)area/nodegroup) and kind (e.g.kind/improvement)Testing
Created a cluster on real outpost. Then added a node using the following command:
The node failed joining initially, because of a bug in the DescribeCluster EKS API for the outpost use case. We return the port for the cluster endpoint (see below), which causes
nodeadmto fail resolving the cluster endpoint DNS. In order to do the end-to-end test, I sanitized the endpoint and the node was able to join.I decided to fix the EKS API, instead of sanitizing the DescribeCluster output in
eksctl.BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯