Relax stdlib check when detecting stdlib location #1217
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This PR fixes a crash that happens if Elixir has been built with the `ERL_COMPILER_OPTIONS=deterministic` compiler flag. That flag causes the build to strip out the source tag from the compilation info of stdlib modules. When finding the Elixir sources, we elixir-ls would crash because `enum_ex_path` is nil when the source tag isn't set and `File.exists?/2` does not support nil as its first argument. This PR relaxes the constraint by first checking whether `enum_ex_path` is nil, in which case a different log message is printed before returning false. Fixes elixir-lsp#1197
Author
| Closed in favor of #1216 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR fixes a crash that happens if Elixir has been built with the
ERL_COMPILER_OPTIONS=deterministiccompiler flag. That flag causes the build to strip out the source tag from the compilation info of stdlib modules.When finding the Elixir sources, we elixir-ls would crash because
enum_ex_pathis nil when the source tag isn't set andFile.exists?/2does not support nil as its first argument.This PR relaxes the constraint by first checking whether
enum_ex_pathis nil, in which case a different log message is printed before returning false.Fixes #1197