Simplified ESP32 code + siren effect #23
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…Tone + removed associated default values. Added setVolume() for ESP32 bases on duty cycle. Fixed issue on ESP32 of inconsistent sound when calling ledcWriteTone while a sound is already playing.
… ESP32 Ardiuino Framework. Also removed volume() function whch was not really working and is ESP32 specific...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Hi Evert,
I made some changes to your EasyBuzzer library :
Pleas let me know if you want to merge this code or if you need me to make any modification before that.
Best regards,
Frederic.