Fix SD character width #80
Conversation
|
|
| I think we made it 31 in an effort to fix the crosshair? Or something like that? The code doesn’t lie so I’m happy to merge this so it matches haha …On Fri, Oct 14, 2022 at 2:26 PM Dan ***@***.***> wrote: [image: image] <https://user-images.githubusercontent.com/622619/195915692-688423c5-fb1e-4842-ab6b-17d88c87bf69.png> — Reply to this email directly, view it on GitHub <#80 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABTO2MVIHMJP3UVKLTAVP3WDGQU5ANCNFSM6AAAAAARFPBYMA> . You are receiving this because your review was requested.Message ID: ***@***.***> |
| Think Ben was doing something like that for the FakeHD but we're all full even now! 😄 |
benlumley force-pushed the main branch 3 times, most recently from 636fd3d to 5ae3026 Compare 
I used 59 briefly because some guys on discord wanted their cross hair centered; we even had a brief argument when I pointed out it was never centered on SD and they insisted it was! Anyway - when inav implemented the full size grid; 60 was clearly a winner - so i moved fakehd back. |
It was absolutely me. 😂 Can't unsee now. |
| Haha. That's even better! |
Seems it's actually 30 wide!
https://github.com/betaflight/betaflight/blob/master/src/main/osd/osd.h#L48
Mainly, it's an issue for the OSD overlay renderer because it uses this to chop out the active area and center it. So with the current values out of the OSD files, everything's shifted left one tile. It's not been a problem in the goggles since the x/y offset takes care of it.
It's also high comedy because it means the THREE TILE WIDE crosshair is totally uncenterable and always has been, even for analog.