Skip to content

Removing undefined's from filter arguments #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 16, 2016
Merged

Removing undefined's from filter arguments #137

merged 1 commit into from
Nov 16, 2016

Conversation

@pedro-ribeiro
Copy link
Contributor

@pedro-ribeiro pedro-ribeiro commented Nov 16, 2016

  • Removes trailing comma. java String#split has a different behaviour from componentsseparatedbystring, which leads to a bug.
  • Problem resides in equalTo passing undefined to setFilter when no key is present.
  • Not tested besides equalTo filter in android! Can break other filters. Requires further testing.
@pedro-ribeiro pedro-ribeiro mentioned this pull request Nov 16, 2016
Open
@auser auser merged commit a0a78e5 into fullstackreact:master Nov 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@pedro-ribeiro @auser