Fix auth user and user map #95
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor Author
| Also upgrades firebase to 9.8.0, which fixes a bug that prevented you from using your own notification icon (firebase/quickstart-android#4) |
Various fixes / changes: - dont call removeDBHandlers() when calling .on() - Dont destroy and recreate the monolithic listener for each path - handleDatabaseEvent only forwards it to javascript if anyone is listening to that eventType Previously: - Calling ref.on(eventType) would erase pre-existing listeners - eventType handlers were getting called with the wrong eventType
Contributor Author
| Really this should've been two PRs, but meh. Listeners should be much more reliable now. If anyone has been experiencing weirdness with firebase seemingly losing connections, this PR might fix your problems. But no promises 👍 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
userwasn't actually being used inuserCallback. I changed all usages tothis.usersyntax to make it more clear if it's a field variable or not.Similarly, the
WritableMap userMap = getUserMap();wasn't being used, so userCallback wasn't being populated correctly