Skip to content

Conversation

@joejordanbrown
Copy link

When no width is set and the component element chart is not display: block; the .highcharts-container can have the wrong width calculated.

When no width is set and the component element `chart` is not `display: block;` the .highcharts-container can have the wrong width calculated.
@tibysko
Copy link

tibysko commented Feb 19, 2017

Thanks for this! I just added 'display: block' to the chart tag 👍

@gevgeny
Copy link
Owner

gevgeny commented Feb 19, 2017

Should we really fix this ? If you need your chart to be block you can do it in the client code

@joejordanbrown
Copy link
Author

It should be display: block; on the host element because almost all components that contain inner element data are display block by default in HTML for example <div>, <p>, <section>, <footer>, <article>, <aside>. So this is expected with Angular components too. It's been discussed on the Angular GitHub page but it's a breaking change, so that's my guess why it hasn't been changed as the default for all Angular components.

@lebnic
Copy link

lebnic commented Mar 8, 2017

This bug's been affecting me aswell; fix is good, thanks :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants