Migrate pull_requests toolset to Go SDK #1466
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
LuluBeatson changed the title pullrequests toolset to Go SDKpull_requests toolset to Go SDK Copilot finished reviewing on behalf of LuluBeatson November 21, 2025 13:50
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR migrates all 10 tools from the pull_requests toolset to use the new modelcontextprotocol/go-sdk instead of the older mark3labs/mcp-go framework. The migration involves updating function signatures, schema definitions, error handling patterns, and test assertions.
Key changes:
- Function signatures now return 3 values
(*mcp.CallToolResult, any, error)instead of 2 - Schema definitions migrated from builder pattern to direct
jsonschema.Schemastructs - Error handling uses new
utils.NewToolResultErrorhelpers that setIsError: true
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
pkg/github/tools.go | Uncommented pull requests toolset registration to enable the migrated tools |
pkg/github/pullrequests.go | Migrated all 10 pull request tools to new SDK with updated signatures, schemas, and error handling |
pkg/github/pullrequests_test.go | Updated tests to work with new SDK: removed build ignore tag, updated schema assertions, and fixed handler call signatures |
pkg/github/__toolsnaps__/*.snap | Updated 10 toolsnap files reflecting new schema structure (field order, annotations format) |
Contributor Author
Screenshots          |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Closes: Part of #1428
Migrates all 10 tools from the
pull_requeststoolset to using modelcontextprotocol/go-sdk