Check if the tool is _NOT_ read only before skipping it in read-only mode

[omgitsads]

Previously these were pointers to a Bool, now they are concrete types and this was incorrectly ported in the Go SDK move.

Closes:

[Copilot]

Pull request overview

This PR fixes a critical logic error in the RegisterSpecificTools function that was incorrectly ported during the Go SDK migration. The bug inverted the condition for skipping write tools in read-only mode, causing the function to skip read-only tools instead.

Key Change:

• Corrects the condition from if tool.Tool.Annotations.ReadOnlyHint && readOnly to if !tool.Tool.Annotations.ReadOnlyHint && readOnly to properly skip write tools (those without the ReadOnlyHint) when in read-only mode

Comments suppressed due to low confidence (1)

pkg/toolsets/toolsets.go:332

• The corrected read-only mode filtering logic lacks test coverage. Consider adding a test case in pkg/toolsets/toolsets_test.go that verifies RegisterSpecificTools correctly skips write tools (where ReadOnlyHint is false) when readOnly=true is passed, and that it registers read-only tools (where ReadOnlyHint is true).

if !tool.Tool.Annotations.ReadOnlyHint && readOnly {	// Skip write tools in read-only mode	skippedTools = append(skippedTools, toolName)	continue	} 

---

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.