Skip to content

Conversation

@juruen
Copy link
Collaborator

@juruen juruen commented Mar 18, 2025

Context

This PR adds a tool for creating an issue. We initially postponed this feature to wait for mcp-go to support arrays for describing arguments.

The library finally added support for arrays a few days ago. However, my first implementation, which used them, caused issues in VS Code.

Since VS Code is my main test platform, I decided to implement the array using a comma-separated list instead. We can revisit this decision once the issue is resolved.

Screenshot 2025-03-18 at 15 41 26

Copilot AI review requested due to automatic review settings March 18, 2025 14:40
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new tool called "create_issue" to enable creating issues in a GitHub repository using a comma-separated list for multi-value fields, along with associated tests and documentation updates.

  • Added unit tests for parseCommaSeparatedList and createIssue functionality.
  • Introduced the createIssue tool implementation and registered it in the server.
  • Updated README documentation to include the new create_issue tool and its parameters.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
pkg/github/server_test.go Added tests for parseCommaSeparatedList functionality.
pkg/github/issues_test.go Added tests for createIssue tool covering success and failure cases.
README.md Documentation updated for the new create_issue tool and its parameters.
pkg/github/issues.go Added createIssue tool implementation using comma-separated list parsing.
pkg/github/server.go Registered the createIssue tool and provided a local parseCommaSeparatedList.

Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more

Copy link
Collaborator

@SamMorrowDrums SamMorrowDrums left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK @juruen can you make an issue to re-visit the CSV style, and use proper JSON RPC arrays once it works?

@juruen
Copy link
Collaborator Author

juruen commented Mar 20, 2025

OK @juruen can you make an issue to re-visit the CSV style, and use proper JSON RPC arrays once it works?

Done! #31

@juruen juruen merged commit 26e3c6c into main Mar 20, 2025
3 checks passed
@juruen juruen deleted the juruen/create-issue branch March 20, 2025 17:17
manian0430 pushed a commit to ChrisLally/github-mcp-server that referenced this pull request Apr 12, 2025
DaleSeo pushed a commit to DaleSeo/github-mcp-server that referenced this pull request Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants