[Python] generate enums as IntEnum or IntFlag type when requested #8782
+107 −33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
github-actions bot added c++ codegen 
fliiiix reviewed Nov 18, 2025
fliiiix reviewed Nov 18, 2025
Contributor
| Some docs at least in |
Contributor
| I played around a bit and it seemed fine, i couldn't integrated it into our main product because this crate was not updated yet rdelfin/flatbuffers-build#30 |
jtdavis777 changed the title fliiiix reviewed Nov 20, 2025
fliiiix reviewed Nov 20, 2025
fliiiix reviewed Dec 3, 2025
| if (version_.major == 3) { | ||
| imports->Import("enum", "IntEnum"); | ||
| stub << "(IntEnum)"; | ||
| if (parser_.opts.python_enum) { |
Contributor
There was a problem hiding this comment.
Ahh i finally got it to work on my project and i spotted an other bug if you just limit to python_enum here you will break for people who enabled just --python-typing
enum Symbology : uint { DEFAULT = 0x00, NO_READ = 0x02, } table Barcode { symbology: Symbology; value: string; } will generate
def Symbology(self) -> typing.Literal[Symbology.DEFAULT, Symbology.NO_READ] which only works if Symbology is a enum in python.
This should be addressed before we merge this that without the python_enum the old typing code is generated, and with the new code with better types.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes #8617 and addresses #5083
This PR has enum types inherit from
IntEnumor (IntFlagforbit_flags) directly, instead of just providing this as type hinting, and changes the setter function signatures to require enum types. This code should still be backward and forward compatible on receipt, as ints are still returned by the getters.This code, chiefly, allows users to go to and from string string values to the enum values, but also provides some runtime type safety (over just type hint safety).