Fix Android Automl remote model sample crash #92
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
| Hey! It looks like this PR contains the two commits with the snippets. Can we separate them out? Or we can also just merge this PR and abandon this #91? |
Collaborator Author
| I see. Could we just merge this and abandon #91? Thanks! |
Collaborator
| Sounds good, let's do it! |
ta-tomschell pushed a commit to ta-tomschell/mlkit that referenced this pull request Apr 4, 2025
…l_sample_crash Fix Android Automl remote model sample crash
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
We don't have a local model in this sample, so should already wait for remote model downloading to be finished first.