cleaned up notebooks added to gfql demo folder, readme update #559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
lmeyerov reviewed Jul 5, 2024
| @@ -0,0 +1,2976 @@ | |||
| { | |||
Contributor
There was a problem hiding this comment.
instead of making a new file & url, replace the old file
(and revert any changed links)
lmeyerov reviewed Jul 5, 2024
lmeyerov reviewed Jul 10, 2024
README.md Outdated
| ``` | ||
| | ||
| * GFQL: Cypher-style graph pattern mining queries on dataframes with optional GPU acceleration ([ipynb demo](demos/more_examples/graphistry_features/hop_and_chain_graph_pattern_mining.ipynb), [benchmark](demos/gfql/benchmark_hops_cpu_gpu.ipynb)) | ||
| * GFQL: Cypher-style graph pattern mining queries on dataframes with optional GPU acceleration ([ipynb demo](demos/more_examples/graphistry_features/hop_and_chain_graph_pattern_mining.ipynb), [chain and hop demo](demos/gfql/simple_gfql_notebook.ipynb), [benchmark](demos/gfql/gfql_cpv_gpu_enchmark.ipynb) |
lmeyerov reviewed Jul 10, 2024
README.md Outdated
| PyGraphistry supports GFQL, its PyData-native variant of the popular Cypher graph query language, meaning you can do graph pattern matching directly from Pandas dataframes without installing a database or Java | ||
| | ||
| See also [graph pattern matching tutorial](demos/more_examples/graphistry_features/hop_and_chain_graph_pattern_mining.ipynb) and the CPU/GPU [benchmark](demos/gfql/benchmark_hops_cpu_gpu.ipynb) | ||
| See also [graph pattern matching tutorial](demos/more_examples/graphistry_features/hop_and_chain_graph_pattern_mining.ipynb), [starting with chain and hop](demos/gfql/simple_gfql_notebook.ipynb) and the CPU/GPU [benchmark](demos/gfql/gfql_cpv_gpu_enchmark.ipynb) |
lmeyerov requested changes Jul 10, 2024
Contributor
lmeyerov left a comment
lmeyerov left a comment There was a problem hiding this comment.
fix dangling links from stale edit and that's it!
lmeyerov reviewed Jul 15, 2024
README.md Outdated
| ``` | ||
| | ||
| * GFQL: Cypher-style graph pattern mining queries on dataframes with optional GPU acceleration ([ipynb demo](demos/more_examples/graphistry_features/hop_and_chain_graph_pattern_mining.ipynb), [benchmark](demos/gfql/benchmark_hops_cpu_gpu.ipynb)) | ||
| * GFQL: Cypher-style graph pattern mining queries on dataframes with optional GPU acceleration ([ipynb demo](demos/more_examples/graphistry_features/hop_and_chain_graph_pattern_mining.ipynb),[benchmark](demos/gfql/gfql_hops_cpu_gpu.ipynb) |
Contributor
There was a problem hiding this comment.
this shouldn't be changed, should still be old benchmark_hops_cpu_gpu, not gfql_...
lmeyerov reviewed Jul 15, 2024
| | ||
| See also [graph pattern matching tutorial](demos/more_examples/graphistry_features/hop_and_chain_graph_pattern_mining.ipynb) and the CPU/GPU [benchmark](demos/gfql/benchmark_hops_cpu_gpu.ipynb) | ||
| See also [graph pattern matching tutorial](demos/more_examples/graphistry_features/hop_and_chain_graph_pattern_mining.ipynb), and the CPU/GPU [benchmark](demos/gfql/gfql_hops_cpu_gpu.ipynb) | ||
| |
lmeyerov requested changes Jul 15, 2024
Contributor
lmeyerov left a comment
lmeyerov left a comment There was a problem hiding this comment.
- still need to back out readme.md url changes
- readme.md has conflicts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.