-
- Notifications
You must be signed in to change notification settings - Fork 412
Bump to 2.4.0.1 #3863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump to 2.4.0.1 #3863
Conversation
f1499ad to d68e7f4 Compare | Please don't drop 9.8.1 support, head.hackage should be working now. |
Running Unless there is a proper fix for head.hackage, building HLS 2.4.0.0 with GHC 9.8 will no longer work. |
| We don't depend on head.hackage anymore, so if you rebase the build should work for 9.8.1 |
Confirmed. |
54507ef to 6236a51 Compare | I think this should be a major bump now |
Can we avoid that? |
| No, the lsp version we depend on had breaking changes. |
I'm not sure I understand. Why can't we rebase on the previous release and just backport the removal of head.hackage without any further changes? |
It will not build with GHC 9.8. |
So the lsp version didn't backport the GHC 9.8 compatibility patch to the older branch? |
I never said that. See #3861 (comment) for instructions on how to reproduce. If I remember correctly, |
| I don't have time at the moment to pursue this release. |
Release checklist
.github/workflows/release.yamlghc: [to find all lists.TODO:to find locations that require extra care for GHC versions.*.cabalfiles (same version as hls)hie-compatrequires no automatic version bump.shake-benchis an internal testing tool, not exposed to the outside world. Thus, no version bump required for releases../GenChangelogs.hs <api-key> <tag><tag>is the git tag you want to generate the ChangeLog from.<api-key>is a github access key: https://github.com/settings/tokenswip/<version>git switch -c wip/<version><version>git tag <version>git push <remote> <version>sh scripts/release/download-gh-artifacts.sh <version> <your-gpg-email>gh-release-artifacts/haskell-language-server-<version>/gh-release-artifacts/haskell-language-server-<version>/cd gh-release-artifacts/haskell-language-server-<version>SIGNING_KEY=... ../../release/upload.sh uploadgpg --list-secret-keys --keyid-format=longhttps://downloads.haskell.org/~hls/haskell-language-server-<version>/SIGNING_KEY=... ../../release/upload.sh purge_allto remove CDN cachesghcup-0.0.7.yamlandghcup-vanilla-0.0.7.yamlsh scripts/release/create-yaml-snippet.sh <version>to generate a snippet that can be manually inserted into the yaml fileshls-metadata-0.0.1.jsoncabal run ghcup-gen -- generate-hls-ghcs -f ghcup-0.0.7.yaml --format json --stdoutin the root of ghcup-metadata repository