Add a minimal example of web service #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
maosenhuang reviewed Jan 5, 2023
| replicas: replicas[env], | ||
| template: { | ||
| metadata: { labels }, | ||
| spec: { |
Collaborator
There was a problem hiding this comment.
no config map in the example right?
Contributor Author
There was a problem hiding this comment.
Right. Thus it can be run without cloning the git repo.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The current
nginxexample requires local directory access since version0.2.0, so the usage as documented in thereadme.mddoes not work.To fix the issue, a new minimal example is added.