Skip to content

fix: client wasm ci-test using removed snapshot function #2840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 3, 2025
Merged

fix: client wasm ci-test using removed snapshot function #2840

merged 2 commits into from
Dec 3, 2025

Conversation

@Alenar
Copy link
Collaborator

@Alenar Alenar commented Dec 3, 2025 •
edited
Loading

Content

This PR fix a regression introduced in #2821: the long deprecated get_snapshot and list_snapshots were removed from the wasm client but ... still used in the wasm ci-test script.
The fix is to use the function that superseded them: get_cardano_database_snapshot and list_cardano_database_snapshots.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • All check jobs of the CI have succeeded
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • No new TODOs introduced

Issue(s)

Relates to #2758
Alenar added 2 commits December 3, 2025 18:03
@Alenar
fix(client-wasm): ci-test was still using removed snapshot functions
4990357 
instead of the `cardano_database_snapshot` function that superseded them
@Alenar
chore: upgrade crate versions
1ee2721 
* [js] client-wasm-ci-test from `0.3.13` to `0.3.14`
@Alenar Alenar requested a review from jpraynaud December 3, 2025 17:05
@Alenar Alenar self-assigned this Dec 3, 2025
jpraynaud
jpraynaud approved these changes Dec 3, 2025
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@github-actions
Copy link

github-actions bot commented Dec 3, 2025

Test Results

    4 files  ±0    168 suites  ±0   23m 24s ⏱️ -11s
2 223 tests ±0  2 223 ✅ ±0  0 💤 ±0  0 ❌ ±0 
6 933 runs  ±0  6 933 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 1ee2721. ± Comparison against base commit 78a2890.
@Alenar Alenar temporarily deployed to testing-preview December 3, 2025 17:15 — with GitHub Actions Inactive
@Alenar Alenar merged commit 97c27bd into main Dec 3, 2025
41 checks passed
@Alenar Alenar deleted the djo/2758/fix-stabilize-cdb-v2-phase4-client-wasm branch December 3, 2025 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@Alenar @jpraynaud