Skip to content

Fix segmentation fault on Python 3.13 #960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix segmentation fault on Python 3.13 #960

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
452fddb
Fix segmentation fault on Python 3.13
shadchin Nov 27, 2025
d14b921
Re-enable the regular tests for 3.13
shadchin Nov 27, 2025
639f7ee
Add include
shadchin Nov 27, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/msgspec/_core.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5337,6 +5337,11 @@ Struct_alloc(PyTypeObject *type) {
if (obj == NULL) return NULL;
/* Zero out slot fields */
memset((char *)obj + sizeof(PyObject), '\0', type->tp_basicsize - sizeof(PyObject));
#if PY313_PLUS && !PY314_PLUS
if (type->tp_flags & Py_TPFLAGS_INLINE_VALUES) {
_PyObject_InitInlineValues(obj, type);
Copy link
Contributor

@provinzkraut provinzkraut Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it's worth asking upstream about how to deal with this without relying on private APIs?

Not like we don't rely on private APIs elsewhere, so I wouldn't consider it a blocker, but if there's a way, that might be nice?
}
#endif
return obj;
}

Expand Down