Skip to content

Mirror video in fullscreen. #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Mirror video in fullscreen. #32

wants to merge 1 commit into from

Conversation

@MisterDA
Copy link
Contributor

@MisterDA MisterDA commented Jan 9, 2021

All that is needed is a parent node to the video, and request fullscreen on that node instead of the video.
Tested on latest versions of Chrome and Firefox on Android and Linux.
Fix #4.
@jech
Copy link
Owner

jech commented Jan 23, 2021 •
edited
Loading

I'm not comfortable with the use of parentNode, I feel it's fragile, it will break as soon as we change the DOM structure. I've done a fair amount of work in the pre-0.1 times to replace all DOM walks with calls to getElementById, as the code becomes more complex, it becomes ever more important to avoid strong coupling between galene.html and galene.js.
@jech jech force-pushed the master branch 2 times, most recently from dd6d4c6 to b660bc4 Compare March 13, 2021 15:30
@jech jech force-pushed the master branch 5 times, most recently from 5c390a8 to b1bb427 Compare April 30, 2021 18:46
@jech jech force-pushed the master branch 2 times, most recently from ace55c3 to 32663db Compare May 9, 2021 15:49
@jech jech force-pushed the master branch 3 times, most recently from 6eeac02 to de78f3c Compare May 18, 2021 11:51
@jech jech force-pushed the master branch 2 times, most recently from 4f84b48 to 0d2ca28 Compare July 15, 2021 23:40
@jech jech force-pushed the master branch 2 times, most recently from 65fa0be to 03038ea Compare January 11, 2024 21:05
@jech jech force-pushed the master branch 2 times, most recently from b7172df to 8de77fe Compare October 30, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@MisterDA @jech