[php2cpg] fix: remove superflous method ref #5706
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ml86 reviewed Dec 4, 2025
Comment on lines +812 to +813
| case xs => | ||
| fail(s"Expected two method refs, got ${xs.methodFullName.mkString("[", ",", "]")}") |
Contributor
There was a problem hiding this comment.
Please dont put this kind of error handling if it is just restating the previous case condition. It is just extra code without any use and a MatchException is totally fine if the condition does not hold.
ml86 approved these changes Dec 4, 2025
TNSelahle changed the title Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Remove superflous method ref
Fixes https://github.com/ShiftLeftSecurity/codescience/issues/8574