add library.json file #19
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Owner
| PlatformIO is supposed to support the library.properties manifest. Do you know why it doesn't work in some cases? If there's a particular character or field it doesn't like, I can fix the current file. |
Author
| I know it's supposed to support the properties file, but it doesn't work for me without the .json version. Without the json file I get this error: lib/sunrisesunset/sunrisesunset.cpp:3:10: fatal error: SolarCalculator.h: No such file or directory ************************************************************************* * Looking for SolarCalculator.h dependency? Check our library registry! * * CLI > platformio lib search "header:SolarCalculator.h" * Web > https://registry.platformio.org/search?q=header:SolarCalculator.h * ************************************************************************* 3 | #include <SolarCalculator.h> | ^~~~~~~~~~~~~~~~~~~ compilation terminated. With the .json file tests run clean. I've even removed the include and platform lines from the json and it still works. I have no idea why. It's not a big issue, I can maintain my fork easily. …On Mon, Jan 16, 2023 at 8:24 AM jpb10 ***@***.***> wrote: PlatformIO is supposed to support the library.properties manifest. Do you know why it doesn't work in some cases? If there's a particular character or field it doesn't like, I can fix the current file. — Reply to this email directly, view it on GitHub <#19 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAS2FAEMOJ2XM5DH27JX623WSVKZNANCNFSM6AAAAAAT4EXSWU> . You are receiving this because you authored the thread.Message ID: ***@***.***> |
Owner
| Let me look into it, I don't mind adding the json file if necessary. |
Author
| If it would help I could either give you a login to my gitlab server or upload the project to another location, the project this occurs in is actually very small. James …On Tue, Jan 17, 2023 at 9:22 AM jpb10 ***@***.***> wrote: Let me look into it, I don't mind adding the json file if necessary. — Reply to this email directly, view it on GitHub <#19 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAS2FAGRUPIJKM5NC6PH5MTWS22KDANCNFSM6AAAAAAT4EXSWU> . You are receiving this because you authored the thread.Message ID: ***@***.***> |
Owner
| Yes, whatever you prefer. Also, consider asking the people at platformio... it could be very obvious to them. |
Author
| https://github.com/james-w-shoemaker/esp-sunrisesunset pio test to run the tests, it pulls from my fork so things work. Change https://github.com/james-shoemaker/SolarCalculator.git in platformio.ini and library.json to point to jpb10/SolarCalculator to make it hit your repo. or just remove the library.json file from the .pio tree. …On Tue, Jan 17, 2023 at 9:59 PM jpb10 ***@***.***> wrote: Yes, whatever you prefer. Also, consider asking the people at platformio... it could be very obvious to them. — Reply to this email directly, view it on GitHub <#19 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAS2FAALTI5U4VVI3TZCAVLWS5TCJANCNFSM6AAAAAAT4EXSWU> . You are receiving this because you authored the thread.Message ID: ***@***.***> |
Owner
| Can you try adding the following line to platformio.ini:
This seems to get past the library dependency finder issues, but I'm getting various undeclared/undefined errors... so I'm not able to finish the build. |
Author
| That does resolve the issue for that project. I'll experiment and see if it causes any issues. Odd you are getting undeclared/undefined things, I don't. James …On Sat, Jan 21, 2023 at 1:08 PM jpb10 ***@***.***> wrote: Can you try adding the following line to platformio.ini: lib_compat_mode = off This seems to get past the library dependency finder issues, but I'm getting various undeclared/undefined errors... so I'm not able to finish the build. — Reply to this email directly, view it on GitHub <#19 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAS2FAFUBY7OEI2COE44KRTWTQX3LANCNFSM6AAAAAAT4EXSWU> . You are receiving this because you authored the thread.Message ID: ***@***.***> |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
PlatformIO works better with a library.json file. I realize the file isn't completely correct, but my platformIO native test builds don't work without it.