feature: useEventListener EventMap generic override + EventTarget & refactor: multiple overloads to single mapped type #657
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Changelog
This PR introduces several improvements aimed at reducing complexity and increasing flexibility in the codebase:
🔨 Refactor: Reduced Code Duplication:
✨ Feature: Enhanced Type Safety:
config.elementargument) + AudioNode...🔨 Refactor: Parameter Simplification:
config.In Depth Changes
🔨 Refactor: Improved Readability & future refactors (by decreasing code size)
Replaced Overloads with Generic map from Element (string) to [Element, EventMap] tuple + 2 Utility constructs
✨ Feature: Enhanced Type Safety
Custom EventMap Generic (overrides all Event to Element Mapping declarations in hook)
Globally declared CustomEventMap always available (applied to all DOM Elements, except when custom generic is used)
🔨 Refactor Parameter Simplification
Optional Arguments
element?: RefObject<T>&options?: boolean | AddEventListenerOptionsmoved to single optional Object argumentconfigAdding a new ref Element to Event map
Previously an overload was needed (+6 lines). Now adding a key-value pair to the ElementToEventMap: which value is a tuple containing the element type and its corresponding event map type (+1 line)
Usage Preview